-
-
Notifications
You must be signed in to change notification settings - Fork 31
Full rewrite for JSX4, records with optional fields + simplicity #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How should we release this ? Any idea for the version number ?
Closed
It seems there is a coming 7.0 version of react-navigation, maybe we could wait for the others breaking changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This is more or less a full rewrite of the existing bindings that I implemented for our company's projects in the last months.
It is meant for the latest ReScript (10.1.2) + @rescript/react 0.11.0 in JSX4 mode.
It
@obj
creation functions for all options/config/param objectsNavigator.Make
functions)params
type as an argument to theMake
functor - which IMHO is of no use at all and actually incorrect, as not all screens in a stack navigator can be assumed to have the same params shape.I currently do not have time for documentation or for a comprehensive example, so I am just putting this out there like it is.