Improve stack and material top tabs #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

MoOx merged 2 commits into rescript-react-native:main from reck753:improve-stack-and-material-top-tabs

Apr 13, 2022

Merged

Improve stack and material top tabs #51

MoOx merged 2 commits into rescript-react-native:main from reck753:improve-stack-and-material-top-tabs

Apr 13, 2022

Conversation

reck753

Copy link

Contributor

@reck753 reck753 commented Jan 10, 2022

Hi!

I improved Stack binding by adding:

headerBackTestID option
getId screen prop
and improved MaterialTopTabs by adding swipeEnabled screen option since setting it through props is deprecated.

reck753 added 2 commits

January 10, 2022 17:04

@reck753


 Improve Stack by adding:

2bd76b0

- `headerBackTestID` screen option
- `getId` screen prop

@reck753


 Add swipeEnabled option to MaterialTopTabs

1fbc362

@MoOx MoOx requested a review from Freddy03h

January 14, 2022 17:47

MoOx

MoOx approved these changes

Jan 14, 2022

View reviewed changes

Copy link

Member

@MoOx MoOx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice!

@reck753

Copy link

Contributor Author

reck753 commented Jan 14, 2022

Thanks, nice!

You are welcome!

@MoOx, I know it is not the best place to ask, but could you check svg and webview bindings? I have some PRs open there. svg PR is nothing much, while webview is a bit bigger change, more like a proposition.
Thanks!