-
-
Notifications
You must be signed in to change notification settings - Fork 31
ScreenWithCallback for tabs navigators #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScreenWithCallback for tabs navigators #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but can you have a look to my comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be declared as a standard record?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, I copied the way it was done on the Stack 😅
https://github.com/reason-react-native/reason-react-navigation/blob/a7d40f04e6785ed0c4525ad2b5f63a287282cf7f/src/Stack.re#L127
https://github.com/reason-react-native/reason-react-navigation/blob/a7d40f04e6785ed0c4525ad2b5f63a287282cf7f/src/Stack.re#L269-L282
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so we could change that later in all places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question here (not sure it's doable for some reason)
Thank you! 😁
ScreenWithCallback for BottomTabs, MaterialBottomTabs and MaterialTopTabs navigators, to match the Stack navigator.