-
-
Notifications
You must be signed in to change notification settings - Fork 31
Add none header option #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cknitt
merged 6 commits into
rescript-react-native:master
from
DCKT:add_none_header_option
Nov 15, 2019
Merged
Add none header option #17
cknitt
merged 6 commits into
rescript-react-native:master
from
DCKT:add_none_header_option
Nov 15, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks again! Something is weird here though, Github shows me the changes from the previously merged two PRs (reset, headerShown) in this PR, too?
Indeed, I made this upon these other changes because I needed it (did It
too fast)
Le 15 novembre 2019 à 16:52:12, Christoph Knittel (notifications@github.com)
a écrit:
Thanks again! Something is weird here though, Github shows me the changes
from the previously merged two PRs (reset, headerShown) in this PR, too?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#17>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAL2BBNFVS4WQDNYZ7DZ3ATQT3ASZANCNFSM4JMCDMEQ>
.
Yes, that's totally fine, but the two others are already merged, so I would have expected to see only one change when comparing against the current master.
I'll try to merge and see what happens.
Ok, it's fine, when merged I see just the one change in the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The
headeroption can benullfollowing the documentation, so I added an externalCheers