Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: comment before else and and #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zweimach wants to merge 1 commit into rescript-lang:main from zweimach:newline-comment

Conversation

Copy link
Contributor

@zweimach zweimach commented Feb 15, 2024

This fixes errors when parsing comments and newlines before else clauses and decorated and bindings.

(let_declaration
(let_binding
(value_identifier)
(number))
Copy link
Contributor

@Emilios1995 Emilios1995 Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Looks like there's a comment missing right here before the decorator.

aspeddro reacted with thumbs up emoji
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I just realized that after I made this PR. I think the _newline_and_comment node discards the comment in this particular position.

@zweimach zweimach deleted the newline-comment branch April 12, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Emilios1995 Emilios1995 Emilios1995 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /