Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

remove docker argument -d in DockerTimeout.sh #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flywu wants to merge 1 commit into remoteinterview:master
base: master
Choose a base branch
Loading
from flywu:master

Conversation

@flywu
Copy link

@flywu flywu commented Apr 14, 2017

with -d ,docker can't bootup because of conflict of argument -d and argument --rm

Copy link

Dose removing -d option work?
I got error.

{ [Error: Command failed: time="2017-04-20T23:29:52+09:00" level=fatal msg="cannot enable tty mode on non tty input"
] killed: false, code: 1, signal: null } '' 'time="2017-04-20T23:29:52+09:00" level=fatal msg="cannot enable tty mode on non tty input" \n'

Instead, when I run with only -d option(deleting --rm), it works well.!

Copy link
Author

flywu commented Apr 20, 2017 via email

In my situation, removing -d option does well. But that i remove —rm and run only with -d option also does work ok !
...
在 2017年4月20日,22:33,JeongTaekLim ***@***.***> 写道: Dose removing -d option work? I got error. { [Error: Command failed: time="2017-04-20T23:29:52+09:00" level=fatal msg="cannot enable tty mode on non tty input" ] killed: false, code: 1, signal: null } '' 'time="2017-04-20T23:29:52+09:00" level=fatal msg="cannot enable tty mode on non tty input" \n' Instead, when I run with only -d option(deleting --rm), it works well.! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#31 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFookb6VKj2DJYIva6FvnU32rWbeRtwhks5rx2yygaJpZM4M9rS1>.

Copy link

JeongtaekLim commented Apr 21, 2017
edited
Loading

Thank you for reply.
Can you tell me your os?
Mine is Ubuntu 14.04 LTS

Copy link
Author

flywu commented Apr 21, 2017 via email

My docker runs on boot2docker , a toolbox for macOS. My macOS is 10.12.3. i have seen your issues#32 , but i didn’t get into your problem on the first step.I run command ‘npm install’ and ‘node app.js’ well.
...
在 2017年4月21日,10:06,JeongTaekLim ***@***.***> 写道: Thank you for reply. Can you tell me your os? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#31 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFookUaK44CD_I3eHzbecSVNDB0hkEPdks5ryA8-gaJpZM4M9rS1>.

Copy link

This change is necessary.

Official Docs : https://docs.docker.com/engine/reference/run/#clean-up-rm

DollarAkshay reacted with thumbs up emoji

Copy link

I've tried in a Digital Ocean droplet with CentOS and removing -d didn't work, while removing --rm did work.

Copy link
Contributor

asadm commented Nov 18, 2017

As I understand this issue -d and --rm are not conflicting anymore. The official docs also say:

By design, containers started in detached mode exit when the root process used to run the container exits, unless you also specify the --rm option. If you use -d with --rm, the container is removed when it exits or when the daemon exits, whichever happens first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /