-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
bmarini
commented
May 17, 2018
I just noticed that the aws sdk has two useful looking sub packages that might be able to replace the attribute/query building code in this client.
https://godoc.org/github.com/aws/aws-sdk-go/service/dynamodb/dynamodbattribute
https://godoc.org/github.com/aws/aws-sdk-go/service/dynamodb/expression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we care about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If #109 is merged, then we can just remove all of this and use PutItemWithContext. To add tracing to the client, with the table name included in the spans:
s := contrib.WithTracing(session.New()) c := dynamodb.New(s) c.Handlers.Send.PushBack(func(r *request.Request) { span := opentracing.SpanFromContext(r.Context()) span.SetTag(dd_opentracing.SpanType, "db") span.SetTag("aws.table_name", dt.tableName) })
cddec42 to
46305d4
Compare
ejholmes
commented
Jun 26, 2018
I rebased this, and added two commits:
- Removes
sendWithTracing, since Simpler AWS opentracing #109 was merged. - Changes
dynamo_client.NewDynamoDBClientto accept aclient.ConfigProviderso you can provide a*session.Sessionwrapped with tracing.
Kevin-Jonaitis
commented
Feb 25, 2021
Changing to "WIP". If you would like this to be reviewed, please convert back from WIP and we'll take a look.
This is a pretty simple dynamodb client that supports apm tracing and takes an an input a map of table descriptions (to be used in testing and in production for table creation).