-
-
Notifications
You must be signed in to change notification settings - Fork 207
Increase touch area of comment collapse button on mobile #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sparronator9999
wants to merge
1
commit into
redlib-org:main
from
Sparronator9999:summary-padding-fix
Open
Increase touch area of comment collapse button on mobile #520
Sparronator9999
wants to merge
1
commit into
redlib-org:main
from
Sparronator9999:summary-padding-fix
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds extra padding to the left of the "arrow" marker on comment threads, improving the consistency of the touch area to the left of the commenter's username (which previously didn't extend past the left side of the arrow marker).
This change should improve the overall UX of Redlib by making comments easier to collapse (since I believe most users won't know you can tap to the right of the username and creation date, and will go straight for the arrow marker instead). Since the area is increased on the left side of the "arrow" marker, it will also reduce accidental taps of the commenter's username (taking them to the user's page, which counts against Reddit's rate limiting).
Closes #500.