-
-
Notifications
You must be signed in to change notification settings - Fork 207
fix(video): add support for CMAF video format alongside DASH #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reddit has transitioned from DASH to CMAF video format. This change adds
support for both formats to maintain compatibility.
Changes:
- Update REGEX_URL_VIDEOS to match both DASH and CMAF formats
- Add format capture group to preserve DASH/CMAF in URL path
- Add separate proxy endpoints for /vid/:id/dash/:size and /vid/:id/cmaf/:size
- Update format_url to handle 3-segment video URLs (id/format/size)
- Update tests to reflect new URL format with format segment
Video URLs now follow pattern: /vid/{id}/{format}/{size}.mp4
Example: /vid/abc123/cmaf/720.mp4
espacedev3019
added a commit
to espacedev3019/redlib
that referenced
this pull request
Jan 17, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reddit has transitioned from DASH to CMAF video format. This change adds support for both formats to maintain compatibility.
Changes:
Video URLs now follow pattern: /vid/{id}/{format}/{size}.mp4
Example: /vid/abc123/cmaf/720.mp4
Fixes #503
Fixes #504