-
Notifications
You must be signed in to change notification settings - Fork 648
Conversation
ddtch
commented
Jan 8, 2025
someone please pay attention to this PR
jquense
commented
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to skip it conditionally based on React version
koba04
commented
Jan 10, 2025
@jquense
Yeah, CI fails are caused because of old dependencies and the Node version, and react-transition-group works with React v19 as long as we use nodeRef, so I think this doesn't block anything.
I'd say we should update our build settings , outdated dependencies and documentation system before updating React version.
jquense
commented
Jan 10, 2025
you wanna do it?
koba04
commented
Jan 11, 2025
Yeah, I'll do it when I have time, but it would be helpful someone takes that.
The documentation also depends on PropTypes, which was removed in v19, so it would be better to update the documentation as well.
(Keeping PropTypes won't have any issues, it's just ignored, so this isn't a requirement)
https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-deprecated-react-apis
sergioviniciuss
commented
Feb 5, 2025
it would be so helpful if this MR would be included soon🙏
koba04
commented
Feb 21, 2025
@sergioviniciuss
I think react-transition-group works with React v19, do you have any issue that this can fix?
danielstclair
commented
Feb 24, 2025
@koba04 I'm seeing an issue when using the Transition component on React v19:
TypeError: react_dom__WEBPACK_IMPORTED_MODULE_3___default(...).findDOMNode is not a function
@koba04 I'm seeing an issue when using the Transition component on React v19:
TypeError: react_dom__WEBPACK_IMPORTED_MODULE_3___default(...).findDOMNode is not a function
You need to add a ref and it'll work like this:
<CSSTransition nodeRef={nodeRef} . . </CSSTransition>
This will make it not crash but it will still fail on typing through eslint, so you might want to disable it for that.
Uh oh!
There was an error while loading. Please reload this page.
This only updates CI settings and tests.
react-transition-groupseems to work with React 19 without any updates