Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat!: support React19 & drop React 16,17 support#915

Draft
koba04 wants to merge 2 commits intomaster from
react-19
Draft

feat!: support React19 & drop React 16,17 support #915
koba04 wants to merge 2 commits intomaster from
react-19

Conversation

@koba04
Copy link
Member

@koba04 koba04 commented Dec 24, 2024
edited
Loading

This only updates CI settings and tests. react-transition-group seems to work with React 19 without any updates

Copy link

ddtch commented Jan 8, 2025

someone please pay attention to this PR

Copy link
Collaborator

jquense commented Jan 9, 2025

its in draft and not passing CI @ddtch what do you want us to pay attention to??

@koba04 lmk when this is updated to pass CI

koba04 reacted with thumbs up emoji

});
});

it('should use `React.findDOMNode` when `nodeRef` is not provided', () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to skip it conditionally based on React version

Copy link
Member Author

koba04 commented Jan 10, 2025

@jquense
Yeah, CI fails are caused because of old dependencies and the Node version, and react-transition-group works with React v19 as long as we use nodeRef, so I think this doesn't block anything.

I'd say we should update our build settings , outdated dependencies and documentation system before updating React version.

Copy link
Collaborator

jquense commented Jan 10, 2025

you wanna do it?

Copy link
Member Author

koba04 commented Jan 11, 2025

Yeah, I'll do it when I have time, but it would be helpful someone takes that.

The documentation also depends on PropTypes, which was removed in v19, so it would be better to update the documentation as well.
(Keeping PropTypes won't have any issues, it's just ignored, so this isn't a requirement)

https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-deprecated-react-apis

Copy link

it would be so helpful if this MR would be included soon🙏

Copy link
Member Author

koba04 commented Feb 21, 2025

@sergioviniciuss
I think react-transition-group works with React v19, do you have any issue that this can fix?

Copy link

@koba04 I'm seeing an issue when using the Transition component on React v19:

TypeError: react_dom__WEBPACK_IMPORTED_MODULE_3___default(...).findDOMNode is not a function
ryochin, Neraste, and TheSecondPower reacted with thumbs up emoji

Copy link

samin15 commented Mar 7, 2025
edited
Loading

@koba04 I'm seeing an issue when using the Transition component on React v19:

TypeError: react_dom__WEBPACK_IMPORTED_MODULE_3___default(...).findDOMNode is not a function

You need to add a ref and it'll work like this:
<CSSTransition nodeRef={nodeRef} . . </CSSTransition>

This will make it not crash but it will still fail on typing through eslint, so you might want to disable it for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Comments

AltStyle によって変換されたページ (->オリジナル) /