-
Notifications
You must be signed in to change notification settings - Fork 648
fix: perform sync update when exiting animation#885
Open
asapach wants to merge 1 commit intoreactjs:master from
Open
fix: perform sync update when exiting animation #885asapach wants to merge 1 commit intoreactjs:master from
asapach wants to merge 1 commit intoreactjs:master from
Conversation
otomad
added a commit
to otomad/react-transition-group
that referenced
this pull request
Apr 19, 2024
reactjs#885 When running in React 18 concurrent mode some state updates are batched, which results in inconsistent timing of events compared to the legacy mode. For example when using animations, after animationend event fires, the onExited event is not fired immediately, so there is a brief period of time when animation is finished and the styles are reset back to normal, which may cause a flash or a jump. One of these scenarios is described in reactjs#816. This change makes sure that the updates are performed synchronously, in order to make sure that events fire consistently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running in React 18 concurrent mode some state updates are batched, which results in inconsistent timing of events compared to the legacy mode. For example when using animations, after
animationendevent fires, theonExitedevent is not fired immediately, so there is a brief period of time when animation is finished and the styles are reset back to normal, which may cause a flash or a jump. One of these scenarios is described in #816.This change makes sure that the updates are performed synchronously, in order to make sure that events fire consistently.