Update get-started.md | Removes deprecation warning for webpackconfig in favor of generateWebpackConfig #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

justin808 merged 1 commit into reactjs:master from chmod600:patch-1

May 10, 2024

Merged

Update get-started.md | Removes deprecation warning for webpackconfig in favor of generateWebpackConfig #1337

justin808 merged 1 commit into reactjs:master from chmod600:patch-1

May 10, 2024

Conversation

chmod600

Copy link

Contributor

@chmod600 chmod600 commented Apr 27, 2024 •

edited

Loading

Summary

Using webpackconfig throws a deprecation warning and encourages user to use generateWebpackConfig() instead. Updates docs to avoid this deprecation warning.

Other Information

Output: 
 $ ./bin/shakapacker-dev-server
⚠️
DEPRECATION NOTICE:
The 'webpackConfig' is deprecated and will be removed in a future version.
Please use 'globalMutableWebpackConfig' instead, or use
'generateWebpackConfig()' to avoid unwanted config mutation across the app.
For more information, see version 7 upgrade documentation at:
https://github.com/shakacode/shakapacker/blob/master/docs/v7_upgrade.md

Pull Request checklist

[x ] Add/update test to cover these changes
[ x] Update documentation
[ x] Update CHANGELOG file

@chmod600


 Update get-started.md

02a5b72

Using webpackconfig throws a deprecation warning and encourages user to use generateWebpackConfig() instead.

G-Rath

G-Rath approved these changes

May 4, 2024

View reviewed changes

Copy link

Contributor

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

docs/get-started.md

});

const webpackConfig = generateWebpackConfig()

module.exports = merge(

Copy link

Contributor

@G-Rath G-Rath May 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not blocking, but fwiw this can be simplified further as generateWebpackConfig now takes a config to be merged in:

module.exports = generateWebpackConfig({
 plugins: [new ForkTsCheckerWebpackPlugin()]
});

@justin808 justin808 merged commit 151d333 into reactjs:master

May 10, 2024

Labels

None yet

3 participants

@chmod600 @G-Rath @justin808

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update get-started.md | Removes deprecation warning for webpackconfig in favor of generateWebpackConfig #1337

Update get-started.md | Removes deprecation warning for webpackconfig in favor of generateWebpackConfig #1337

Uh oh!

Conversation

@chmod600 chmod600 commented Apr 27, 2024 •

edited

Loading

Uh oh!

Summary

Other Information

Pull Request checklist

Uh oh!

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

Uh oh!

@G-Rath G-Rath May 4, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Update get-started.md | Removes deprecation warning for webpackconfig in favor of generateWebpackConfig #1337

Update get-started.md | Removes deprecation warning for webpackconfig in favor of generateWebpackConfig #1337

Uh oh!

Conversation

@chmod600 chmod600 commented Apr 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Other Information

Pull Request checklist

Uh oh!

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

Uh oh!

@G-Rath G-Rath May 4, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

@chmod600 chmod600 commented Apr 27, 2024 •

edited

Loading