-
Notifications
You must be signed in to change notification settings - Fork 752
Ci Fixes #1336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci Fixes #1336
Conversation
4ca5db5 to
081e33c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems weird that we have to use sudo but not that concerned since this in a temp CI runner 😁
(I figure it might be related to supporting old versions of Node and what not)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sudo is to resolve a EACCES: permission denied error that I was getting.
The other option I saw in my search was --unsafe-perm, but that's apparently obsolete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not in the gemspec as a development dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because CI doesn't install development dependencies from the gemspec.
Do you want me to create a Gemfile.development_dependencies file like react_on_rails has?
Uh oh!
There was an error while loading. Please reload this page.
This PR addresses linting and some other CI issues in preparation for #1335