Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ci: run rubocop on pull requests #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Judahmeek merged 1 commit into reactjs:master from G-Rath:run-rubocop-on-pr
Dec 8, 2023
Merged

ci: run rubocop on pull requests #1321

Judahmeek merged 1 commit into reactjs:master from G-Rath:run-rubocop-on-pr
Dec 8, 2023

Conversation

Copy link
Contributor

@G-Rath G-Rath commented Dec 7, 2023

Summary

Currently rubocop failures are not properly coming through on pull requests because the workflow only runs on push - this is why e.g. #1320 was able to slip through

Pull Request checklist

  • (削除) Add/update test to cover these changes (削除ここまで)
  • (削除) Update documentation (削除ここまで)
  • (削除) Update CHANGELOG file (削除ここまで)

Copy link
Collaborator

Judahmeek commented Dec 8, 2023
edited
Loading

@G-Rath According to my research (I believe this was one of my sources), the following configuration should eliminate any redundant job trigger, but also guarantee that CI runs on all PRs (including PRs from forks) and on pushes to master as well.

on:
 push:
 branches:
 - 'master'
 pull_request:

Copy link
Contributor Author

G-Rath commented Dec 8, 2023

@Judahmeek yup you're right and that would be my preference but my change matches the other workflow - I'm happy to do a follow up PR changing both workflows to run only on pushes to master

Copy link
Collaborator

@G-Rath Fair enough. Although I would have just combined #1320, #1321, and said follow-up, I understand & respect your reasons for not doing so.

Btw, how did you notice my merge of #1320 so quickly?

@Judahmeek Judahmeek merged commit 9fdbefb into reactjs:master Dec 8, 2023
@G-Rath G-Rath deleted the run-rubocop-on-pr branch December 8, 2023 04:31
Copy link
Contributor Author

G-Rath commented Dec 8, 2023

Follow up PR is here: #1322

Btw, how did you notice my merge of #1320 so quickly?

I got a notification in my inbox and just... actioned it 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /