Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add devcontainer configuration#1344

Open
JamesHutchison wants to merge 7 commits into
reactive-python:main from
JamesHutchison:add-devcontainer
Open

Add devcontainer configuration #1344
JamesHutchison wants to merge 7 commits into
reactive-python:main from
JamesHutchison:add-devcontainer

Conversation

@JamesHutchison

@JamesHutchison JamesHutchison commented Mar 19, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adds a developer container configuration and updates all references to Python 3.9 to 3.11

Checklist

Please update this checklist as you complete each item:

  • (削除) Tests have been developed for bug fixes or new functionality. (削除ここまで)
  • (削除) The changelog has been updated, if necessary. (削除ここまで)
  • (削除) Documentation has been updated, if necessary. (削除ここまで)
  • (削除) GitHub Issues closed by this PR have been linked. (削除ここまで)

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

This addresses #597 which was closed a while back.

@JamesHutchison JamesHutchison left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to clean this up and do a clean rebuild.

One consideration is that I don't see a way to spawn a test server that you can easily tweak. I have a non-committed main.py. It would be a better practice if someone could just grab a launch config and start a server that they can hand test (in my case, I was testing that disabling javascript indeed shows the noscript page)

Comment thread .devcontainer/devcontainer.json Outdated
Comment on lines +7 to +14
// "remoteUser": "vscode",
// "containerEnv": {
// "BUN_INSTALL": "/home/vscode/.bun"
// },
// "remoteEnv": {
// "BUN_INSTALL": "/home/vscode/.bun",
// "PATH": "/home/vscode/.bun/bin:${containerEnv:PATH}"
// },

@JamesHutchison JamesHutchison Mar 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove

Comment thread .devcontainer/devcontainer.json Outdated
"ms-python.python",
"ms-python.vscode-pylance",
"charliermarsh.ruff",
"ms-playwright.playwright"

@JamesHutchison JamesHutchison Mar 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extensions were plugged in with AI and should be updated to respect a sane workflow. No idea what this playwright extension is.

Comment thread .gitignore

# --- IDE ---
.idea
.vscode

@JamesHutchison JamesHutchison Mar 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the .idea folder is intended to be private to a user, this is not the case for .vscode which is intended to be a workspace specific configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /