Skip to content

Navigation Menu

Sign in
Sign up

Add Custom Animation to the Logo - #109

Open
akuya-ekorot wants to merge 3 commits into
reactdeveloperske:develop from
akuya-ekorot:logo-animation
Open

Add Custom Animation to the Logo #109
akuya-ekorot wants to merge 3 commits into
reactdeveloperske:develop from
akuya-ekorot:logo-animation

Conversation

@akuya-ekorot

@akuya-ekorot akuya-ekorot commented Nov 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes Issue #108

Closes #108

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

2022年11月14日_03-01-16.mp4

Note to reviewers

  • It's not a video file, nor a gif but an animated svg with data in a json file. This makes it scale without pixelation and saves on space.
  • The total size of the animated logo is 110kbs
  • The packages "react-lottie" and "@types/react-lottie" were installed to implement this.

vercel Bot commented Nov 14, 2022

Copy link
Copy Markdown

@akuya-ekorot is attempting to deploy a commit to a Personal Account owned by @reactdeveloperske on Vercel.

@reactdeveloperske first needs to authorize it.

vercel Bot commented Nov 15, 2022 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reactdevske-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 10:23am

@antosan antosan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akuya-ekorot Nice touch on the Logo there, this looks really great.

Before merging this in, can you please add some documentation for people who have never worked with Lottie animations before? I want to be sure that we have enough information to maintain this code once merged in.

Please add a section in the README with information like What is Lottie? How is the JSON file generated? How can the animation be changed? and any other useful information that would help in the future maintenance of this code.

While at it, also kindly resolve the merge conflicts.

akuya-ekorot reacted with thumbs up emoji

Copy link
Copy Markdown
Member

Hello @akuya-ekorot, any progress on the requested changes for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antosan antosan antosan requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Custom Logo Animation

AltStyle によって変換されたページ (->オリジナル) /