-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Avoid vector insert in mixed shared children persistence test - #2009
Open
Hashim1999164 wants to merge 1 commit into
Open
Avoid vector insert in mixed shared children persistence test #2009Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
@facebook-github-tools
facebook-github-tools
Bot
added
the
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
label
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Fixes #1934
YGPersistenceTest mixed_shared_and_owned_children used vector insert at begin plus one. GCC 16 with O2 or O3 reports a false array bounds warning, and the tests are built with warnings as errors.
The test now builds the three child pointers explicitly and passes that list to setChildren, which is the same layout without insert.