-
Notifications
You must be signed in to change notification settings - Fork 1.6k
validate grid track index in grid template and auto setters - #1973
validate grid track index in grid template and auto setters #1973netliomax25-code wants to merge 1 commit into
Conversation
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
YGNodeStyleSetGridTemplateColumn/Row, theirMinMaxvariants, and theGridAutoequivalents) pass the caller'sindexstraight intoStyle::setGrid*At, which writes the backingGridTrackListvector throughoperator[]....Countresize call) is an out-of-bounds heap write rather than a rejected argument; ASan reports a heap-buffer-overflow write inStyle::setGridTemplateColumnAt.index < <list>.size()withassertFatalWithNodebefore forwarding, so an out-of-range index is rejected the same way other public index APIs already are.Validated with a unit test that fails on the unpatched tree (OOB write under ASan) and passes after, covering the in-range path plus an out-of-range call for all four track lists.