-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Correct three entries in the v0.88.0-rc.0 changelog - #58421
Closed
fabriziocucci wants to merge 1 commit into
Closed
Correct three entries in the v0.88.0-rc.0 changelog #58421fabriziocucci wants to merge 1 commit into
fabriziocucci wants to merge 1 commit into
Conversation
@meta-cla
meta-cla
Bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Sep 9, 2026
@facebook-github-tools
facebook-github-tools
Bot
added
p: Facebook
Partner: Facebook
Partner
labels
Sep 9, 2026
@fabriziocucci has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119308634.
fabriziocucci
force-pushed
the
export-D119308634
branch
from
September 9, 2026 12:21
5895da6 to
01fd431
Compare
cortinico
cortinico
approved these changes
Sep 9, 2026
@cortinico
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review automatically exported from Phabricator review in Meta.
Summary: Three corrections to the `v0.88.0-rc.0` section of `CHANGELOG.md`. 1. Remove the `Touchable` root export entry. That removal already shipped in `v0.87.0` under a cherry-picked commit, so it is not new in 0.88 and its entry is a duplicate. 2. Reword the iOS `RCTArrayBuffer` entry. It sits under Breaking but read as a plain addition, which hid the part that actually breaks. Codegen now emits `RCTArrayBuffer *` for TurboModule methods taking or returning an `ArrayBuffer`, where 0.87 shipped `NSMutableData *` for both arguments and returns, so modules that adopted ObjC `ArrayBuffer` support in 0.87 stop compiling until they update. `RCTArrayBuffer` derives from `NSObject` rather than `NSData`, so there is no implicit conversion to soften the change. 3. Move the Android `ArrayBuffer` entry from Fixed to Added, and rewrite it. Its source commit carries two `Changelog:` blocks and the generator took the category from the first and the text from the second, leaving a sentence fragment with no verb. Java `ArrayBuffer` support is itself new in this release, so the use-after-free the commit hardens against never reached a published version and a Fixed entry would describe a bug no user experienced. The borrow contract is API semantics for a new type, so the entry now sits with the other two Java `ArrayBuffer` entries under Added. Both rewritten entries are also tightened from three sentences to two. At 429 and 324 characters they were the two longest entries in the file; the longest is now 321, against a p90 of 149 for the section and a 406-character precedent in v0.87.0. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D119308634
fabriziocucci
force-pushed
the
export-D119308634
branch
from
September 9, 2026 13:41
01fd431 to
72fce23
Compare
This pull request has been merged in adb688a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary:
Three corrections to the
v0.88.0-rc.0section ofCHANGELOG.md.Remove the
Touchableroot export entry. That removal already shipped inv0.87.0under a cherry-picked commit, so it is not new in 0.88 and its entry is a duplicate.Reword the iOS
RCTArrayBufferentry. It sits under Breaking but read as a plain addition, which hid the part that actually breaks. Codegen now emitsRCTArrayBuffer *for TurboModule methods taking or returning anArrayBuffer, where 0.87 shippedNSMutableData *for both arguments and returns, so modules that adopted ObjCArrayBuffersupport in 0.87 stop compiling until they update.RCTArrayBufferderives fromNSObjectrather thanNSData, so there is no implicit conversion to soften the change.Move the Android
ArrayBufferentry from Fixed to Added, and rewrite it. Its source commit carries twoChangelog:blocks and the generator took the category from the first and the text from the second, leaving a sentence fragment with no verb. JavaArrayBuffersupport is itself new in this release, so the use-after-free the commit hardens against never reached a published version and a Fixed entry would describe a bug no user experienced. The borrow contract is API semantics for a new type, so the entry now sits with the other two JavaArrayBufferentries under Added.Both rewritten entries are also tightened from three sentences to two. At 429 and 324 characters they were the two longest entries in the file; the longest is now 321, against a p90 of 149 for the section and a 406-character precedent in v0.87.0.
Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D119308634