Skip to content

Fix "Cannot read property 'canonical' of undefined" in Fabric getListener when event target is not a live fiber #58418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

heecheolman wants to merge 1 commit into react:main

from heecheolman:fix/getlistener-undefined-statenode

+6 −6

Open

Fix "Cannot read property 'canonical' of undefined" in Fabric getListener when event target is not a live fiber #58418

Changes from all commits

Commits

Show all changes

Select commit

Fix TypeError in Fabric getListener when event target stateNode is un...

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

4 changes: 2 additions & 2 deletions packages/react-native/Libraries/Renderer/implementations/ReactFabric-dev.js

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -996,7 +996,7 @@ __DEV__ &&
		}
		function getListener1ドル(inst, registrationName) {
		inst = inst.stateNode;
	if (null === inst) return null;
	if (null == inst) return null;
		inst = getFiberCurrentPropsFromNode1ドル(inst);
		if (null === inst) return null;
		if ((inst = inst[registrationName]) && "function" !== typeof inst)
Expand Down Expand Up		@@ -1136,7 +1136,7 @@ __DEV__ &&
		}
		function getListener(inst, registrationName) {
		inst = inst.stateNode;
	if (null === inst) return null;
	if (null == inst) return null;
		inst = getFiberCurrentPropsFromNode1ドル(inst);
		if (null === inst) return null;
		if ((inst = inst[registrationName]) && "function" !== typeof inst)
Expand Down

4 changes: 2 additions & 2 deletions packages/react-native/Libraries/Renderer/implementations/ReactFabric-prod.js

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -672,7 +672,7 @@ function traverseTwoPhase1ドル(inst, fn, arg) {
		}
		function getListener1ドル(inst, registrationName) {
		inst = inst.stateNode;
	if (null === inst) return null;
	if (null == inst) return null;
		inst = getFiberCurrentPropsFromNode1ドル(inst);
		if (null === inst) return null;
		if ((inst = inst[registrationName]) && "function" !== typeof inst)
Expand Down Expand Up		@@ -1086,7 +1086,7 @@ var plugins = [],
		registrationNameModules = {};
		function getListener(inst, registrationName) {
		inst = inst.stateNode;
	if (null === inst) return null;
	if (null == inst) return null;
		inst = getFiberCurrentPropsFromNode1ドル(inst);
		if (null === inst) return null;
		if ((inst = inst[registrationName]) && "function" !== typeof inst)
Expand Down

4 changes: 2 additions & 2 deletions packages/react-native/Libraries/Renderer/implementations/ReactFabric-profiling.js

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -737,7 +737,7 @@ function traverseTwoPhase1ドル(inst, fn, arg) {
		}
		function getListener1ドル(inst, registrationName) {
		inst = inst.stateNode;
	if (null === inst) return null;
	if (null == inst) return null;
		inst = getFiberCurrentPropsFromNode1ドル(inst);
		if (null === inst) return null;
		if ((inst = inst[registrationName]) && "function" !== typeof inst)
Expand Down Expand Up		@@ -1151,7 +1151,7 @@ var plugins = [],
		registrationNameModules = {};
		function getListener(inst, registrationName) {
		inst = inst.stateNode;
	if (null === inst) return null;
	if (null == inst) return null;
		inst = getFiberCurrentPropsFromNode1ドル(inst);
		if (null === inst) return null;
		if ((inst = inst[registrationName]) && "function" !== typeof inst)
Expand Down