-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Closed
Conversation
Summary: Classify the Apple Fabric Switch C++ headers as private API. Strict API consumers now receive a hard error when including these implementation headers, while React Native builds continue to use them under RN_BUILDING. Propagate the cxxstableapi dependency from the iosswitch Buck target so its exported guarded headers resolve PrivateGuard.h. Changelog: [Internal] Differential Revision: D119171908
@meta-cla
meta-cla
Bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Sep 8, 2026
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119171908.
@facebook-github-tools
facebook-github-tools
Bot
added
p: Software Mansion
Partner: Software Mansion
Partner
p: Facebook
Partner: Facebook
labels
Sep 8, 2026
cortinico
cortinico
approved these changes
Sep 8, 2026
@cortinico
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review automatically exported from Phabricator review in Meta.
This pull request has been merged in 5dcbbae.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Classify the Apple Fabric Switch C++ headers as private API. Strict API consumers now receive a hard error when including these implementation headers, while React Native builds continue to use them under RN_BUILDING.
Propagate the cxxstableapi dependency from the iosswitch Buck target so its exported guarded headers resolve PrivateGuard.h.
Changelog: [Internal]
Differential Revision: D119171908