-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Export the native Fabric UI manager for React (#58398) - #58398
Closed
rubennorte wants to merge 1 commit into
Closed
Export the native Fabric UI manager for React (#58398) #58398rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
@meta-cla
meta-cla
Bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Sep 8, 2026
@facebook-github-tools
facebook-github-tools
Bot
added
p: Facebook
Partner: Facebook
Partner
labels
Sep 8, 2026
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119165837.
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: react#58398 Expose the native Fabric UI manager through `react-native/react-private-interface` so the React renderer can consume it without reading the global directly. Changelog: [Internal] Differential Revision: D119165837
rubennorte
force-pushed
the
export-D119165837
branch
from
September 8, 2026 14:52
71ddef9 to
5db0b63
Compare
@meta-codesync
meta-codesync
Bot
changed the title
(削除) Export the native Fabric UI manager for React (削除ここまで)
(追記) Export the native Fabric UI manager for React (#58398) (追記ここまで)
Sep 8, 2026
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Expose the native Fabric UI manager through `react-native/react-private-interface` so the React renderer can consume it without reading the global directly. Changelog: [Internal] Differential Revision: D119165837
rubennorte
force-pushed
the
export-D119165837
branch
2 times, most recently
from
September 8, 2026 15:25
35315e0 to
43188cf
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Expose the native Fabric UI manager through `react-native/react-private-interface` so the React renderer can consume it without reading the global directly. Changelog: [Internal] Differential Revision: D119165837
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Expose the native Fabric UI manager through `react-native/react-private-interface` so the React renderer can consume it without reading the global directly. Changelog: [Internal] Differential Revision: D119165837
rubennorte
force-pushed
the
export-D119165837
branch
from
September 8, 2026 15:25
43188cf to
095c911
Compare
cortinico
cortinico
approved these changes
Sep 8, 2026
@cortinico
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review automatically exported from Phabricator review in Meta.
rubennorte
force-pushed
the
export-D119165837
branch
from
September 9, 2026 09:08
095c911 to
0446402
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 9, 2026
Summary: Expose the native Fabric UI manager through `react-native/react-private-interface` so the React renderer can consume it without reading the global directly. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D119165837
Summary: Expose the native Fabric UI manager through `react-native/react-private-interface` so the React renderer can consume it without reading the global directly. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D119165837
rubennorte
force-pushed
the
export-D119165837
branch
from
September 9, 2026 09:13
0446402 to
5427c1a
Compare
This pull request has been merged in 73a76dd.
rubennorte
added a commit
to react/react
that referenced
this pull request
Sep 9, 2026
## Summary ReactNativeFeatureFlags and fabricUIManager were introduced in `react-native/react-private-interface` in react/react-native#57940 and react/react-native#58398: https://github.com/react/react-native/blob/73a76ddced2088d925809432fd6b0503f239dbfe/packages/react-native/src/react-private-interface.js#L74 https://github.com/react/react-native/blob/73a76ddced2088d925809432fd6b0503f239dbfe/packages/react-native/src/react-private-interface.js#L87 This migrates the use of globals for those bindings to use the exported values instead. ## How did you test this change? Existing tests and Flow.
github-actions Bot
pushed a commit
to react/react
that referenced
this pull request
Sep 9, 2026
## Summary ReactNativeFeatureFlags and fabricUIManager were introduced in `react-native/react-private-interface` in react/react-native#57940 and react/react-native#58398: https://github.com/react/react-native/blob/73a76ddced2088d925809432fd6b0503f239dbfe/packages/react-native/src/react-private-interface.js#L74 https://github.com/react/react-native/blob/73a76ddced2088d925809432fd6b0503f239dbfe/packages/react-native/src/react-private-interface.js#L87 This migrates the use of globals for those bindings to use the exported values instead. ## How did you test this change? Existing tests and Flow. DiffTrain build for [1d34f91](1d34f91)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary:
Expose the native Fabric UI manager through
react-native/react-private-interfaceso the React renderer can consume it without reading the global directly.Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D119165837