-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Remove RCTInstance runtime diagnostic flags getter/setter - #58384
Closed
javache wants to merge 1 commit into
Closed
Remove RCTInstance runtime diagnostic flags getter/setter #58384javache wants to merge 1 commit into
javache wants to merge 1 commit into
Conversation
Summary: Removes the `RCTInstanceRuntimeDiagnosticFlags` getter and `RCTInstanceSetRuntimeDiagnosticFlags` setter (and the backing static) from the bridgeless `RCTInstance` runtime, on both the iOS and macOS platform copies. The setter had no callers anywhere, so the getter always returned an empty string and the `RN$DiagnosticFlags` JS global was never defined. The `ReactInstance::JSRuntimeFlags::runtimeDiagnosticFlags` field already defaults to an empty string, so the `initializeRuntime` call site now relies on that default with no change in runtime behavior. Changelog: [iOS][Removed] - Remove `RCTInstanceSetRuntimeDiagnosticFlags` and `RCTInstanceRuntimeDiagnosticFlags` Differential Revision: D119072229
@meta-cla
meta-cla
Bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Sep 7, 2026
@facebook-github-tools
facebook-github-tools
Bot
added
p: Facebook
Partner: Facebook
Partner
labels
Sep 7, 2026
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119072229.
This pull request has been merged in 935f733.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Removes the
RCTInstanceRuntimeDiagnosticFlagsgetter andRCTInstanceSetRuntimeDiagnosticFlagssetter (and the backing static) from the bridgelessRCTInstanceruntime, on both the iOS and macOS platform copies.The setter had no callers anywhere, so the getter always returned an empty string and the
RN$DiagnosticFlagsJS global was never defined. TheReactInstance::JSRuntimeFlags::runtimeDiagnosticFlagsfield already defaults to an empty string, so theinitializeRuntimecall site now relies on that default with no change in runtime behavior.Changelog:
[iOS][Removed] - Remove
RCTInstanceSetRuntimeDiagnosticFlagsandRCTInstanceRuntimeDiagnosticFlagsDifferential Revision: D119072229