-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Forward declare NativeModulePerfLogger in TurboModulePerfLogger.h (#58381) - #58381
Open
j-piasecki wants to merge 1 commit into
Open
Forward declare NativeModulePerfLogger in TurboModulePerfLogger.h (#58381) #58381j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
@meta-cla
meta-cla
Bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Sep 7, 2026
@facebook-github-tools
facebook-github-tools
Bot
added
p: Software Mansion
Partner: Software Mansion
Partner
p: Facebook
Partner: Facebook
labels
Sep 7, 2026
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116901579.
@meta-codesync
meta-codesync
Bot
changed the title
(削除) Forward declare NativeModulePerfLogger in TurboModulePerfLogger.h (削除ここまで)
(追記) Forward declare NativeModulePerfLogger in TurboModulePerfLogger.h (#58381) (追記ここまで)
Sep 7, 2026
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 7, 2026
...act#58381) Summary: Under the C++ Stable API RFC, `react/nativemodule/core:core` is public while `reactperflogger:reactperflogger` is classified as "private". `TurboModulePerfLogger.h` is an exported header of the public target and includes `reactperflogger/NativeModulePerfLogger.h`, so it transitively exposes a private header to consumers. `NativeModulePerfLogger` is only named as a `std::unique_ptr<NativeModulePerfLogger>&&` parameter in a declaration, so a forward declaration is sufficient and the include moves to the implementation file. `<cstdint>` is now included explicitly, since it was previously pulled in transitively. This also makes the header consistent with the build config: `reactperflogger` is already a non-exported dep of `react/nativemodule/core:core`, so no BUCK change is needed. Changelog: [Internal] Differential Revision: D116901579
j-piasecki
force-pushed
the
export-D116901579
branch
from
September 7, 2026 11:10
71c0e78 to
179a156
Compare
...act#58381) Summary: Under the C++ Stable API RFC, `react/nativemodule/core:core` is public while `reactperflogger:reactperflogger` is classified as "private". `TurboModulePerfLogger.h` is an exported header of the public target and includes `reactperflogger/NativeModulePerfLogger.h`, so it transitively exposes a private header to consumers. `NativeModulePerfLogger` is only named as a `std::unique_ptr<NativeModulePerfLogger>&&` parameter in a declaration, so a forward declaration is sufficient and the include moves to the implementation file. `<cstdint>` is now included explicitly, since it was previously pulled in transitively. This also makes the header consistent with the build config: `reactperflogger` is already a non-exported dep of `react/nativemodule/core:core`, so no BUCK change is needed. Changelog: [Internal] Differential Revision: D116901579
j-piasecki
force-pushed
the
export-D116901579
branch
from
September 9, 2026 07:43
179a156 to
572f213
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary:
Under the C++ Stable API RFC,
react/nativemodule/core:coreis public whilereactperflogger:reactperfloggeris classified as "private".TurboModulePerfLogger.his an exported header of the public target and includesreactperflogger/NativeModulePerfLogger.h, so it transitively exposes a private header to consumers.NativeModulePerfLoggeris only named as astd::unique_ptr<NativeModulePerfLogger>&¶meter in a declaration, so a forward declaration is sufficient and the include moves to the implementation file.<cstdint>is now included explicitly, since it was previously pulled in transitively.This also makes the header consistent with the build config:
reactperfloggeris already a non-exported dep ofreact/nativemodule/core:core, so no BUCK change is needed.Changelog: [Internal]
Differential Revision: D116901579