-
Notifications
You must be signed in to change notification settings - Fork 693
Conversation
Regenerate API snapshots after the bump. `flow-api-translator` picks up the fix in facebook/flow#9486, which stops treating `async` functions with no explicit return annotation as `void` — updating `DependencyGraph#end` and `MetroServer#end` to their correct `Promise<void>` return type in `packages/metro/API.md`. Changelog: ``` - **[Types]**: `DependencyGraph#end` and `MetroServer#end` are now correctly declared as returning `Promise<void>` rather than `void` ``` Test Plan: ``` yarn typecheck yarn lint yarn build yarn run verify-api-snapshots ``` All pass.
@meta-cla
meta-cla
Bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Sep 7, 2026
robhogan
marked this pull request as ready for review
September 7, 2026 13:23
@facebook-github-tools
facebook-github-tools
Bot
added
the
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
label
Sep 7, 2026
Contributor
@javache has imported this pull request. If you are a Meta employee, you can view this in D119090467.
Contributor
meta-codesync Bot
pushed a commit
to react/react-native
that referenced
this pull request
Sep 8, 2026
Summary: Pull Request resolved: #58391 Regenerate API snapshots after the bump. `flow-api-translator` picks up the fix in facebook/flow#9486, which stops treating `async` functions with no explicit return annotation as `void` — updating `DependencyGraph#end` and `MetroServer#end` to their correct `Promise<void>` return type in `packages/metro/API.md`. Changelog: [Internal] Changelog: **[Types]**: `DependencyGraph#end` and `MetroServer#end` are now correctly declared as returning `Promise<void>` rather than `void` X-link: react/metro#1909 Test Plan: ``` yarn typecheck yarn lint yarn build yarn run verify-api-snapshots ``` All pass. Reviewed By: mweststrate Differential Revision: D119090467 Pulled By: javache fbshipit-source-id: 21b65f90ed511e0cb035917eaf1b0ca399ece855
meta-codesync Bot
pushed a commit
to facebook/relay
that referenced
this pull request
Sep 8, 2026
Summary: X-link: react/react-native#58391 Regenerate API snapshots after the bump. `flow-api-translator` picks up the fix in facebook/flow#9486, which stops treating `async` functions with no explicit return annotation as `void` — updating `DependencyGraph#end` and `MetroServer#end` to their correct `Promise<void>` return type in `packages/metro/API.md`. Changelog: [Internal] Changelog: **[Types]**: `DependencyGraph#end` and `MetroServer#end` are now correctly declared as returning `Promise<void>` rather than `void` X-link: react/metro#1909 Reviewed By: mweststrate Differential Revision: D119090467 Pulled By: javache fbshipit-source-id: 21b65f90ed511e0cb035917eaf1b0ca399ece855
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerate API snapshots after the bump.
flow-api-translatorpicks up the fix in facebook/flow#9486, which stops treatingasyncfunctions with no explicit return annotation asvoid— updatingDependencyGraph#endandMetroServer#endto their correctPromise<void>return type inpackages/metro/API.md.Changelog:
Test Plan:
All pass.