Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Create CarbonAds component and update the placement #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sayzlim wants to merge 6 commits into react-hook-form:master from sayzlim:master

Conversation

Copy link

@sayzlim sayzlim commented Aug 12, 2025

  • Create CarbonAds component for modular integration.
  • Move the ad placement to the top of the sidebar TOC.

Open to suggestions to find a better placement.

Copy link

vercel bot commented Aug 12, 2025
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
react-hook-form-website Ready Preview Comment Aug 12, 2025 5:13pm

Copy link

netlify bot commented Aug 12, 2025
edited
Loading

Deploy Preview for sage-cassata-31d224 ready!

Name Link
🔨 Latest commit 9db013b
🔍 Latest deploy log https://app.netlify.com/projects/sage-cassata-31d224/deploys/689b736c3a0118000886c52f
😎 Deploy Preview https://deploy-preview-1166--sage-cassata-31d224.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

bluebill1049 commented Aug 12, 2025
edited
Loading

Screen.Recording.2025年08月12日.at.10.11.13.pm.mov

thanks for the pr! Perhaps place it under the menu? It's completely blocking the menu atm

Copy link
Author

sayzlim commented Aug 12, 2025

@bluebill1049 check out the latest implementation. We can keep the ad on the top and the ad stays hidden when the users scroll down (so TOC will always stay visible to them).

Copy link
Member

updated here: #1168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /