-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs: Add SubmitErrorHandler to typescript example so it matches the javascript example #1140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
faysvas
wants to merge
2
commits into
react-hook-form:master
from
faysvas:docs/update-handle-submit-typescript-example
Closed
docs: Add SubmitErrorHandler to typescript example so it matches the javascript example #1140
faysvas
wants to merge
2
commits into
react-hook-form:master
from
faysvas:docs/update-handle-submit-typescript-example
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...javascript example
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for sage-cassata-31d224 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sorry for the late review, looks like it's already been updated. 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
When browsing the docs I noticed that the TS and JS Sync examples in the docs for
handleSubmit
were mismatched.Specifically, even though an
onError
handler is defined in the TS example, it isn't passed tohandleSubmit
.handleSubmit(1)
handleSubmit(2)
Another idea might be to update both the javascript and typescript examples to include some validation rules, like this one
from the TS section