-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Warn users that resetting the form while passing values will also reset defaultValues #1132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shaundavin13
wants to merge
3
commits into
react-hook-form:master
from
shaundavin13:warn-users-reset-sets-default-values
Open
Warn users that resetting the form while passing values will also reset defaultValues #1132
shaundavin13
wants to merge
3
commits into
react-hook-form:master
from
shaundavin13:warn-users-reset-sets-default-values
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...et defaultValues Added documentation that warns users that when calling `reset` with `values`, the form's `defaultValues` updates accordingly, which means subsequent calls to `reset` will use the previously passed `values` instead of the form's original `defaultValues`. This helps developers who call `reset` with API responses to be aware that subsequent `reset` only revert back to that API response
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for sage-cassata-31d224 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation that warns users that when calling
resetwithvalues, the form'sdefaultValuesupdates accordingly, which means subsequent calls toresetwill use the previously passedvaluesinstead of the form's originaldefaultValues. This helps developers who callresetwith API responses to be aware that subsequentresetonly revert back to that API response