Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update dev-dependencies. #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexKVal merged 1 commit into react-bootstrap:master from AlexKVal:deps
Jul 6, 2015
Merged

Conversation

Copy link
Member

@AlexKVal AlexKVal commented Jun 29, 2015

eslint
karma-cli

Copy link
Member Author

Should we release next version ?
There are some commits after Jun 13, 2015.

Copy link
Member

mtscout6 commented Jul 6, 2015

LGTM

And yes a release sounds fine to me.

Copy link
Member Author

AlexKVal commented Jul 6, 2015

@taion would you release next version ? 😃

AlexKVal added a commit that referenced this pull request Jul 6, 2015
@AlexKVal AlexKVal merged commit f3c0b19 into react-bootstrap:master Jul 6, 2015
@AlexKVal AlexKVal deleted the deps branch July 6, 2015 18:34
Copy link
Member

taion commented Jul 6, 2015

Been travelling and have had somewhat limited time to keep up. I can release if needed though - which branch and what version?

Copy link
Member Author

AlexKVal commented Jul 7, 2015

Emm.. there is only one branch at this project react-router-bootstrap, so then it will be just next version. Isn't it ?

Copy link
Member

taion commented Jul 7, 2015

Apologies - I thought this was the other repo. Do you want v0.16.1 or v0.17.0?

Copy link
Member Author

AlexKVal commented Jul 7, 2015

I'm looking through the last commits history and there are basically dev-dependencies updates
that don't affect the code generated.

And there is only this Remove 'classnames' dependency as a result of refactoring #76 changing the code patch.
In spite of that classnames is not a dependency now, it wasn't in use anyway till that change.

But.. I don't know how other developers were using or not that not public API removed code.
I propose: Let's do it safely: v0.17.0

Copy link
Member

taion commented Jul 8, 2015

We have v0.17.1 now (I messed up the Bower release for v0.17.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /