-
Notifications
You must be signed in to change notification settings - Fork 163
Add NavDropdown + LinkContainer and MenuItem to visual-test #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NavDropdown + LinkContainer and MenuItem to visual-test #127
Conversation
Sure. So
- We should add the
NavDropdown
to both examples. - I don't think
LinkContainer
actually works with dropdowns right now
Should work after #112 and we can bring back the dropdown visual test.
But anyway if you want this merged, please do add the dropdown to the baseline example.
Ok,
will do it on monday.
On Sat, Oct 17, 2015, 01:41 Jimmy Jia notifications@github.com wrote:
Should work after #112
#112
and we can bring back the dropdown visual test.But anyway if you want this merged, please do add the dropdown to the
baseline example.—
Reply to this email directly or view it on GitHub
#127 (comment)
.
Might be superseded by #129 which adds back the old MenuItem
thing.
I've rebased it on master with #128 and #129 merged and npm run visual-test
It looks as:
screen shot 2015年10月19日 at 1 36 56 pm
Everything else seems OK too.
We should add the
NavDropdown
to both examples.
The point of this is that they match. Probably also add a title to the dropdown.
Closing for staleness.
Based on comment in #126