-
Notifications
You must be signed in to change notification settings - Fork 163
[added] PageItem links support #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM
Need one more sign from @react-bootstrap/collaborators
LGTM, but it looks like it won't auto merge. Can you rebase these changes on the latest master branch?
@mdziekon
mdziekon
force-pushed
the
pageitems
branch
from
August 10, 2015 15:11
df6f0ca to
4365680
Compare
Sure, rebase done
jquense
added a commit
that referenced
this pull request
Aug 10, 2015
[added] PageItem links support
@react-bootstrap/owners should we roll the next patch version with all these new components merged ? 😄
Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements links support for
<PageItem>component as<PageItemLink>.This is how visual test looks like:
react-router-bootstrap-page-item-link