-
Notifications
You must be signed in to change notification settings - Fork 430
Bug fix/double render #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
khaninD
wants to merge
2
commits into
react-bootstrap-table:develop
from
khaninD:bugFix/doubleRender
Closed
Bug fix/double render #72
khaninD
wants to merge
2
commits into
react-bootstrap-table:develop
from
khaninD:bugFix/doubleRender
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@khaninD
khaninD
force-pushed
the
bugFix/doubleRender
branch
from
September 25, 2017 22:32
f4a27bd to
2cf9837
Compare
Hi @khaninD
I thought this issue maybe was caused by storybook rendering mechanism. You may give a try to develop with webpack-dev-server by running yarn start and it should not have this issue.
@Chun-MingChen , you're right!
let's ok this PR, thanks 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you want to see this bug, checkout to 13d87cd and push F12...
you see this:
image
Pure Component fix it...