-
Notifications
You must be signed in to change notification settings - Fork 430
fix linebreak-style #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
HI @khaninD I think you can try to add .editorconfig and the content can be
end_of_line = lf
Not sure if it is work on widows, but if it's work, please consider to use this solution also it's worthy to commit to code base. thanks
@AllenFang , eslint show errors.
image
If i added end_of_line = if to .editorconfig,, new files will be with LF style, but old files will be CRLF ...
If i added end_of_line = if to .editorconfig,, new files will be with LF style, but old files will be CRLF ...
hmm... that's correct, how about you delete the repo and clone again? or use --fix to fix the legacy CRLF files?
Anyway, I dont think disable the linebreak-style is best solution, it will make our codebase without consistency line break, if above solution is not work for you, I think you can enforce the line breaking on widows with CRLF by:
"linebreak-style": ["error", "windows"]
This solution maybe more safety.
Close it due to no response
I use windows and i have CRLF and i have problem with eslint linebreak-style option ... this option cancel of check CRLF or LF linebreak style ...