-
Notifications
You must be signed in to change notification settings - Fork 430
Enhancement/environment #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/environment #53
Conversation
* set npmClient to default instead of yarn to prevent from causing error with older yarn version * ref: lerna/lerna#897
Seems like some people do have commit package-lock.json to repo but some people is not...
https://stackoverflow.com/questions/44206782/do-i-commit-the-package-lock-json-file-created-by-npm-5
so any concern that why we avoid to commit package-lock.json to repo?
The reason why I skip package-lock.json is that I want to keep our repo maintained by one package manager, that is yarn. Therefore, that's the reason why I omit this.
ref: https://github.com/babel/babel/blob/master/.gitignore#L13
However, you may be curious about why I remove all the yarn.lock in folder packages.lerna seems to have some problem with elder yarn version. Therefore, I decided to bootstrap with npm by default instead of yarn. Once yarn has become more stable then correct the version.
Enhancement
lernabootstrap with defaultnpminstead ofyarnto prevent from issue that caused byolderversion of yarnlerna bootstrapafter module installyarn.lockin folderpackages