Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Migrate to React@16.3 for Context API #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AllenFang merged 55 commits into develop from refactor/context-api
Aug 4, 2018
Merged

Conversation

Copy link
Member

@AllenFang AllenFang commented May 13, 2018 •
edited
Loading

  1. No internal store anymore, more props driven and stateless for low level component
  2. Improve data flows
  3. Implement table toolkits: like search and csv export

machour reacted with thumbs up emoji konekoya, chunming-c, waynelai614, and AllenFang reacted with hooray emoji
@AllenFang AllenFang force-pushed the refactor/context-api branch 3 times, most recently from 2bf95d3 to f6508ff Compare May 20, 2018 07:52
Copy link
Member

@chunming-c chunming-c left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I salute you sir 🎉🎉🎉

renderWithFilterCtx(base, baseProps) {
return (
rootProps,
cellEditprops
Copy link
Member

@chunming-c chunming-c May 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cellEditprops => cellEditProps

AllenFang reacted with thumbs up emoji

export default withDataStore(BootstrapTable);
export default withContext(BootstrapTable);

Copy link
Member

@chunming-c chunming-c May 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's extra empty line in ln. 8.

AllenFang reacted with thumbs up emoji
Copy link
Member Author

AllenFang commented May 20, 2018 •
edited
Loading

@Chun-MingChen Just do me a favor, please use create-react-app and use npm link to link react-bootstrap-table-next of this branch to test whether it can backward compatible with < react@16.3.0. This test will help me to decide peerDependency and it's may have a big impact for our user, thanks.

This task I want it to be done before I finish all the tests of this PR!!
chunming-c reacted with hooray emoji

@AllenFang AllenFang force-pushed the refactor/context-api branch 4 times, most recently from faead1d to 16bea7c Compare May 30, 2018 09:50
Copy link
Member

@AllenFang:

Sorry for reply late. I got it and I'll do it instantly.

@AllenFang AllenFang force-pushed the refactor/context-api branch 2 times, most recently from b6cbda0 to a0c592a Compare June 13, 2018 15:31
Copy link
Member Author

Also consider to handle #382 . this issue

@AllenFang AllenFang force-pushed the refactor/context-api branch 3 times, most recently from be27825 to 7b411c8 Compare July 1, 2018 08:17
Copy link
Member Author

#244

Copy link
Member Author

#332

@AllenFang AllenFang changed the title (削除) [WIP] Migrate to React@16.3 for Context API (削除ここまで) (追記) Migrate to React@16.3 for Context API (追記ここまで) Jul 22, 2018
@AllenFang AllenFang force-pushed the refactor/context-api branch 2 times, most recently from 405120b to 046da7e Compare July 28, 2018 07:40
AllenFang added 26 commits August 1, 2018 20:26
@AllenFang AllenFang merged commit a3ba464 into develop Aug 4, 2018
@AllenFang AllenFang deleted the refactor/context-api branch August 4, 2018 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunming-c chunming-c chunming-c left review comments

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /