-
Notifications
You must be signed in to change notification settings - Fork 430
remove handleDebounce incorrect arguments from arrow functions #1506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove handleDebounce incorrect arguments from arrow functions #1506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bonus: corrects typo
@AllenFang @Chun-MingChen For your consideration
Thanks for a great set of packages. Time saving and very useful!
cjmaynar
commented
Nov 13, 2020
I saw this issue upon attempting to upgrade to Webpack 5; thanks for the PR! Would love to see this merged and released to allow this package to work with newest version of Webpack
Sharpek
commented
Feb 22, 2021
Any chance for release?
itsmepetrov
commented
Mar 10, 2021
Hi @AllenFang and @chunming-c, could you please approve this PR and release a new version. I'm trying to upgrade webpack to v5 and this is the last thing which prevents me from that.
janeksmielowski
commented
Mar 12, 2021
What is the chance for a release?
MarlonAEC
commented
Mar 27, 2021
Hi folks!...Any news on this issue!? Cheers!
juniorkibirige
commented
Apr 2, 2021
Error is back
Mix: Laravel Mix v6.0.13
IlanFrumer
commented
Apr 5, 2021
Using this inside vitejs for now
// vite.config.ts const modulesFolder = path.resolve(__dirname, 'node_modules/'); // ... resolve: { alias: { 'react-bootstrap-table2-toolkit-css': `${modulesFolder}/react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.min.css`, 'react-bootstrap-table2-toolkit': `${modulesFolder}/react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.js`, '@': srcFolder, }, },
erhanfirat
commented
Jun 2, 2021
PR is opened on Nov 10,
And I see as time passes new developers getting same error like me.
Don't you think to release?
mah51
commented
Jul 21, 2021
Hi, I have also encountered this problem. Any chance of this being merged soon?
afvieira
commented
Aug 2, 2021
Hi, I have also encountered this problem. Any chance of this being merged soon?
+1
Jarvismkennedy
commented
Sep 10, 2021
Hi, I have also encountered this problem. Any chance of this being merged soon?
+1
steveast
commented
Oct 6, 2021
+1
collynwalte
commented
Oct 11, 2021
I'm having this issue too
jeremy-london
commented
Dec 21, 2021
Im having this issue can we get this MR reviewed and pushed please @AllenFang @itsmepetrov
The workaround in the MR description works, but we also needed to ignore some typescript pieces.. looking forward to updates
Anonymous3105
commented
Jan 4, 2022
Can we get to know the timeline for the merge and release for this?
A lot of people (including me) are facing this issue. I tried the given workaround
use import ToolkitProvider from 'react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.min'; instead.
But I'm still getting the same error.
Please provide the resolution for this.
sheldonsebastian
commented
Jan 19, 2022
+1 on this issue
jamesbaker1
commented
Jan 19, 2022
+1
4 similar comments
xcarlosamm
commented
Feb 25, 2022
+1
regis-samurai
commented
Mar 7, 2022
+1
RuDami
commented
Mar 14, 2022
+1
wcordelo
commented
Mar 15, 2022
+1
duhmojo
commented
Mar 15, 2022
+1 +1 +1 +1 +1
DeDX3
commented
Mar 20, 2022
+1
I'm stuck here too. Used the link you gave but still same issue
spookier
commented
Mar 20, 2022
+1
FYI to all. The workaround by @IlanFrumer works for me. Added it to my resolve rebuilt and all is good again in the app.
Using this inside vitejs for now
// vite.config.ts const modulesFolder = path.resolve(__dirname, 'node_modules/'); // ... resolve: { alias: { 'react-bootstrap-table2-toolkit-css': `${modulesFolder}/react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.min.css`, 'react-bootstrap-table2-toolkit': `${modulesFolder}/react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.js`, '@': srcFolder, }, },
There should still be a release or a statement that the project is inactive. With no activity in nearly 2 years, yet still 70K downloads weekly, this module is an example case of a disaster waiting to happen. If its inactive, just state it so people know what they're getting into.
okay, i'm used comment by duhmojo, but adapted for use with react-app-rewired && react-scripts.
-
yarn add react-app-rewired
-
package.json:
"scripts": {
"start": "react-app-rewired start --scripts-version react-scripts",
"build": "react-app-rewired build --scripts-version react-scripts"
}
- in project root create config-overrides.js with
module.exports = function override(config, env) {
if (!config.resolve) {
config.resolve ={
alias: {
"react/jsx-dev-runtime": "react/jsx-dev-runtime.js",
"react/jsx-runtime": "react/jsx-runtime.js",
'react-bootstrap-table2-toolkit-css': `react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.min.css`,
'react-bootstrap-table2-toolkit': `react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.js`,
}
};
}else {
config.resolve = {
...config.resolve,
alias: {
...config.resolve.alias,
"react/jsx-dev-runtime": "react/jsx-dev-runtime.js",
"react/jsx-runtime": "react/jsx-runtime.js",
'react-bootstrap-table2-toolkit-css': `react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.min.css`,
'react-bootstrap-table2-toolkit': `react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.js`,
}
}
}
return config;
}
-
yarn start
-
???
-
PROFIT
KevinGage
commented
Mar 29, 2022
This is preventing us from updating to react-scripts 5 due to the webpack 5 incompatibility. It seems like a small but critical patch. I'll echo what @duhmojo said. It sure looks like this project has been abandoned by its maintainers. If that's the case it would be great to know. Maybe someone would fork at that point.
Applies pull request react-bootstrap-table#1506 from the original repo: react-bootstrap-table#1506
alex-shepel
commented
May 17, 2022
To use with TypeScript import types separately.
import { ToolkitContextType } from 'react-bootstrap-table2-toolkit';
import ToolkitProvider from 'react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit';
<ToolkitProvider exportCSV {...tableProps}>
{(props: ToolkitContextType) => (
// everything else
)}
</ToolkitProvider>
Swethasri1512
commented
Aug 3, 2023
Please anyone give me solution for this
mustafaasif1
commented
Dec 16, 2023
Use "react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit" instead of "react-bootstrap-table2-toolkit" for importing of Components.
Uh oh!
There was an error while loading. Please reload this page.
Temporary workaround, for anyone who may come across this issue before this PR is merged:
use
import ToolkitProvider from 'react-bootstrap-table2-toolkit/dist/react-bootstrap-table2-toolkit.min';
instead.Problem addressed:
As seen in MDN's web docs, an arrow function...
leading to this error when trying to import the toolkit package.
image
Uncaught ReferenceError: arguments is not defined
Edit for housekeeping: closes #1520