-
Notifications
You must be signed in to change notification settings - Fork 430
Pivot Table support #1385 #1401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pivot Table support #1385 #1401
Conversation
One test is failing, but it's also failing in the master branch,
Summary of all failing tests
FAIL packages/react-bootstrap-table2/test/store/sort.test.js
●くろまる Sort Function › sort › should call custom sort function when sortFunc given
expect(received).toBe(expected)
Expected value to be (using ===):
6
Received:
3
at Object.<anonymous> (packages/react-bootstrap-table2/test/store/sort.test.js:48:34)
at new Promise (<anonymous>)
at node_modules/p-map/index.js:46:16
at processTicksAndRejections (internal/process/task_queues.js:97:5)
@Chun-MingChen I think you are a maintainer. Anything else to fix so this could be merged?
@eitens-mak I will review it, thanks
BTW, @eitens-mak please change the base to develop branch, master is for release. thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason why upgrade node-sass?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forget exactly, but I think I couldn't get the dev environment to build on Ubuntu 18.04
Updated the base branch
cd00c3c to
ef22dc4
Compare
thanks!
Supporting #1385
Needs some more testing and cleanup, but basic functionality is working in the storybook