-
Notifications
You must be signed in to change notification settings - Fork 430
Refactor a little for filter.js in react-bootstrap-table2-filter #1368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AllenFang
merged 2 commits into
react-bootstrap-table:develop
from
CYBAI:refactor-filter
May 17, 2020
Merged
Refactor a little for filter.js in react-bootstrap-table2-filter #1368
AllenFang
merged 2 commits into
react-bootstrap-table:develop
from
CYBAI:refactor-filter
May 17, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing the same operation of comparator might be more straightforward and we don't need to declare a `valid` variable.
@CYBAI
CYBAI
force-pushed
the
refactor-filter
branch
from
May 7, 2020 02:49
aa23330 to
b8ac424
Compare
🇹🇼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
(削除) I can't install dependencies successfully on my local to run tests; also, it seems CI doesn't work either. (削除ここまで)(削除) I will just open this as draft PR first. (削除ここまで)With using Node 7, I can install dependencies successfully now but it seems we have several failures in current master.
Other than existing failures, this PR is ready for review.