-
Notifications
You must be signed in to change notification settings - Fork 30
GHActions: various updates #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rdohms
merged 3 commits into
rdohms:master
from
jrfnl:feature/ghactions-various-updates
Feb 13, 2022
Merged
GHActions: various updates #64
rdohms
merged 3 commits into
rdohms:master
from
jrfnl:feature/ghactions-various-updates
Feb 13, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding `--no-interaction` to "plain" Composer commands to potentially prevent CI hanging if, for whatever reason, interaction would be needed in the future.
Previously, in Travis, when the same branch was pushed again and the "Auto cancellation" option on the "Settings" page had been turned on (as it was for most repos), any still running builds for the same branch would be stopped in favour of starting the build for the newly pushed version of the branch. To enable this behaviour in GH Actions, a `concurrency` configuration needs to be added to each workflow for which this should applied to. More than anything, this is a way to be kind to GitHub by not wasting resources which they so kindly provide to us for free. Refs: * https://github.blog/changelog/2021-04-19-github-actions-limit-workflow-run-or-job-concurrency/ * https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#concurrency
Don't allow PHP 8.1 to fail anymore and start testing against PHP 8.2.
@jrfnl
jrfnl
force-pushed
the
feature/ghactions-various-updates
branch
from
December 27, 2021 21:03
26c189e
to
0fc6b62
Compare
rdohms
rdohms
approved these changes
Feb 13, 2022
@rdohms
rdohms
added
the
CI
This issue or pull request is related to the build process
label
Feb 13, 2022
As usual you are a legend, thanks @jrfnl
You're welcome ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH Actions: always use --no-interaction for Composer
Adding
--no-interaction
to "plain" Composer commands to potentially prevent CI hanging if, for whatever reason, interaction would be needed in the future.GH Actions: auto-cancel previous builds for same branch
Previously, in Travis, when the same branch was pushed again and the "Auto cancellation" option on the "Settings" page had been turned on (as it was for most repos), any still running builds for the same branch would be stopped in favour of starting the build for the newly pushed version of the branch.
To enable this behaviour in GH Actions, a
concurrency
configuration needs to be added to each workflow for which this should applied to.More than anything, this is a way to be kind to GitHub by not wasting resources which they so kindly provide to us for free.
Refs:
GH Actions: update for the release of PHP 8.1
Don't allow PHP 8.1 to fail anymore and start testing against PHP 8.2.