Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Replace outputs with v8.0.1 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
taketo1113 wants to merge 2 commits into railsdiff:main from taketo1113:fix-rails-8.0.1

Conversation

Copy link

@taketo1113 taketo1113 commented Dec 25, 2024

This Pull Request was created to verify the results of rails new for Rails 8.0.1.

It replaces the outputs with the result of running rails new with the --skip-bundle option in Rails 8.0.1.

The following were removed in Rails 8.0:

  • app/assets/config
  • app/channels
  • config/initializers/permissions_policy.rb
  • lib/assets
  • test/channels/application_cable/connection_test.rb

Additionally, the following were removed in Rails 7.2:

  • public/apple-touch-icon-precomposed.png
  • public/apple-touch-icon.png
  • public/favicon.ico

Copy link
Member

jswanner commented Jan 2, 2025

Thanks for the PR. Because we pulled data from this repo using GitHub's API as the data source for RailsDiff (and the limitations that imposes), we need to rewrite commits and recreate tags instead of adding new commits, so I can't really use your PR as is. Instead, it's easier for me to fix the problem directly, which I've done for 8.0.1, but for accuracy, I'll need to do the same for all versions going back to v7.2.0.beta1 (I'm assuming).

taketo1113 reacted with thumbs up emoji

@taketo1113 taketo1113 deleted the fix-rails-8.0.1 branch January 3, 2025 13:00
Copy link
Author

Thank you for your comment.
This PR was intended just for verifying the differences, so it’s not an issue at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /