-
Notifications
You must be signed in to change notification settings - Fork 243
Open
Conversation
The previous code has a bug, in that it assigns the names of the objects, not the objects themselves. It also has complex looping logic setting and examining $marker which in fact does nothing. I found that both count() and empty() do not work as expected on the array returned by the function - I have not worked out why, just avoided their use.
coveralls
commented
Mar 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code has a bug, in that it assigns the names of the objects, not the objects themselves.
It also has complex looping logic setting and examining $marker which in fact does nothing.
I found that both count() and empty() do not work as expected on the array returned by the function - I have not worked out why, just avoided their use.
Note that this does not change the 'click here to download' file.