-
Notifications
You must be signed in to change notification settings - Fork 243
Fix Container::UploadObject() not returning Etag and ContentType - #684
Open
evach-vf wants to merge 1 commit into
Open
Fix Container::UploadObject() not returning Etag and ContentType #684evach-vf wants to merge 1 commit into
evach-vf wants to merge 1 commit into
Conversation
Container::setContent() is resetting both Etag and ContentType so I moved this call before the Container::populateFromResponse() call in order to get those values from the headers.
benms
commented
Jan 5, 2017
For normal build in TravisCI you can modify composer.json, change version of satooshi/php-coveralls to 1.0 (see commit 1bcb1d1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Container::setContent()is resetting bothEtagandContentTypeso I moved this call before theContainer::populateFromResponse()call in order to get those values from the headers.Fix issue #683