Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

🐛 Fixed rfcp by defining component name #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ice-chillios merged 1 commit into r5n-labs:master from whoisryosuke:patch-1
Aug 26, 2018

Conversation

Copy link
Contributor

@whoisryosuke whoisryosuke commented Aug 13, 2018

Can't apply proptypes outside of a class/function without using a named function.

This change defines the component function by the filename, and exports it separately (since directly exported const aren't supported).

Can't apply proptypes outside of a class/function without using a named function. 
This change defines the component function by the filename, and exports it separately (since directly exported const aren't supported).
Copy link
Member

Good point, but probably should also contain this before export. What do you think? :)

${1:${TM_FILENAME_BASE}}.propTypes = {}
ice-chillios reacted with thumbs down emoji

Copy link
Contributor Author

@dsznajder I think the code already includes what you were asking for.

ice-chillios reacted with hooray emoji

@ice-chillios ice-chillios merged commit 02846af into r5n-labs:master Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /