Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

v4 #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ice-chillios merged 10 commits into master from v4
Jan 16, 2022
Merged

v4 #202

ice-chillios merged 10 commits into master from v4
Jan 16, 2022

Conversation

Copy link
Member

@ice-chillios ice-chillios commented Dec 30, 2021
edited
Loading

closes #62 #144 #153

Breaking Changes:

  • Removed deprecated lifecycle methods
  • Added settings, currently those only are applied to snippets applied from search prompt (CMD + Shift + R):
    • prettierEnabled
    • importReactOnTop
    • typescript
    • semiColons
    • singleQuote
    • tabWidth
    • languageScopes
    • typescriptComponentPropsStatePrefix

To research yet:

  • Currently prettier/settings are only applied to snippets triggered via search. Despite that, the extension regenerates and replaces generated.json after settings change, VS Code does not load file even after reload (might be an editor limitation)
  • Because VS Code can't load this changed generated.json snippets scope which is currently changed via settings is not always working properly - still looks like limitation and extension would need to extend its snippets array in package.json => From now I will approve PR's for every js based file recognition.

@ice-chillios ice-chillios marked this pull request as ready for review January 15, 2022 10:07
Copy link
Contributor

@kantorm kantorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome. Can't wait to use it 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kantorm kantorm kantorm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Semi & singleQuotes configuration - [Not available for now]

AltStyle によって変換されたページ (->オリジナル) /