Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

New ts rn snippet with named props interface #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ice-chillios merged 1 commit into r5n-labs:master from nlindroos:ts-rn-named-props-interface
Jun 26, 2020

Conversation

Copy link

@nlindroos nlindroos commented Jun 26, 2020

Hi,

Thanks for a great extension. I didn't find any contributing guidelines, so I hope it's okay to create a PR. Let me know if I've missed something.

tsrnfi creates the following snippet:

import React from 'react'
import { View } from 'react-native'
interface MyComponentProps {
 
}
const MyComponent: React.FunctionComponent<MyComponentProps> = (props) => {
 return (
 <View>
 
 </View>
 )
}
export default MyComponent

Screenshot 2020年06月26日 at 11 41 07

This snippet differs from the existing TypeScript snippets by using the React.FunctionComponent generic interface.

I'd suggest improving the types of all TypeScript snippets by actually typing the constant that holds the React component, as has been done in this PR, not simply the props. Even the types of props is more correct when typed this way, since e.g. props.children is automatically typed by the React.FunctionComponent generic.

ice-chillios reacted with hooray emoji
@ice-chillios ice-chillios merged commit ff29c02 into r5n-labs:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /