-
Notifications
You must be signed in to change notification settings - Fork 446
New ts rn snippet with named props interface #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ice-chillios
merged 1 commit into
r5n-labs:master
from
nlindroos:ts-rn-named-props-interface
Jun 26, 2020
Merged
New ts rn snippet with named props interface #139
ice-chillios
merged 1 commit into
r5n-labs:master
from
nlindroos:ts-rn-named-props-interface
Jun 26, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for a great extension. I didn't find any contributing guidelines, so I hope it's okay to create a PR. Let me know if I've missed something.
tsrnfi
creates the following snippet:Screenshot 2020年06月26日 at 11 41 07
This snippet differs from the existing TypeScript snippets by using the
React.FunctionComponent
generic interface.I'd suggest improving the types of all TypeScript snippets by actually typing the constant that holds the React component, as has been done in this PR, not simply the props. Even the types of
props
is more correct when typed this way, since e.g.props.children
is automatically typed by theReact.FunctionComponent
generic.