-
-
Notifications
You must be signed in to change notification settings - Fork 130
Updating workflows for new scripts #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for quicksnip ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
...o reflect change in folder structure.
@Mathys-Gasnier
Mathys-Gasnier
requested review from
psychlone77 and
saminjay
as code owners
January 1, 2025 16:09
technoph1le
technoph1le
approved these changes
Jan 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me
@Mathys-Gasnier
Mathys-Gasnier
merged commit Jan 1, 2025
711b560
into
quicksnip-dev:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On push we now consolidate language files in addition to what we did before.
When pull requests edit the snippets we also run
checkSnippetFormatting.jswhich checks if the snippets are formatted right.PS: This PR also removes the migration script since it's not usefull anymore.
Since changes in workflows can't be checked until merged, I couldn't test them, but i'm pretty confident they work.
Type of Change
Checklist