Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Update javascript.json #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
r3medy wants to merge 1 commit into quicksnip-dev:main from r3medy:patch-1
Closed

Conversation

Copy link

@r3medy r3medy commented Dec 31, 2024 •
edited
Loading

Added roman to integer code snippet

Description

Type of Change

  • ✨ New snippet
  • πŸ›  Improvement to an existing snippet
  • 🐞 Bug fix
  • πŸ“– Documentation update
  • πŸ”§ Other (please describe):

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

Related Issues

Closes #

Additional Context

Screenshots (Optional)

Click to view screenshots 

Added roman to integer code snippet
Copy link

netlify bot commented Dec 31, 2024 •
edited
Loading

βœ… Deploy Preview for quicksnip ready!

Name Link
πŸ”¨ Latest commit f831d12
πŸ” Latest deploy log https://app.netlify.com/sites/quicksnip/deploys/6774540c1ca1b00009e3019a
😎 Deploy Preview https://deploy-preview-71--quicksnip.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the contribution !
I've seen you have created two PR and closed them before this one ? Is this for any particular issue/reason ?
Please see the following comment on your code before we can move on with your snippet.

" if(!toMiss.includes(i)) {",
" if(next > curr) {",
" output+=(next-curr);",
" toMiss.push(i+1);",
Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having a toMiss array, you could just add 1 to i

Copy link
Collaborator

Hey, we recently updated how snippets are stored, please update your PR to match the changes, you will be able to see how to add snippets in CONTRIBUTING.md.
For ref: #87

@majvax majvax added the update needed Code needs to be updated. label Jan 3, 2025
Copy link
Collaborator

Hey, changes were requested on your PR, but we got no news for more than a week, Closing this as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mathys-Gasnier Mathys-Gasnier Mathys-Gasnier requested changes

Assignees
No one assigned
Labels
update needed Code needs to be updated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle γ«γ‚ˆγ£γ¦ε€‰ζ›γ•γ‚ŒγŸγƒšγƒΌγ‚Έ (->γ‚ͺγƒͺγ‚ΈγƒŠγƒ«) /