-
-
Notifications
You must be signed in to change notification settings - Fork 130
Local Storage Utility (support encode and decode) #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for quicksnip ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
If you strip the types it should be fine as far as I can read.
Perhaps you wish to add Typescript instead?
Hey, thanks for your contribution to the repo.
Snippets to get, set and clear the localstorage already exists, it's true that putting them in a class is a new snippet, but I don't think it fits the scope of the project to put multiple snippets into one like this.
Let's get feedback from other on this topic.
Ashish-simpleCoder
commented
Dec 31, 2024
I think, snippets should be simple to understand and generalized.
Adding encoding and decoding is very specific scenario and few people will be able understand it.
And we should prefer Functional programming instead of class syntax.
And we can modify the existing snippet if want to add additional features.
Personally, I have no use for this snippet. You can already do each of the actions with one line of code. And the encoding and decoding is just base64. New coder's might think it's making their data secure but it's just making it harder to read and nothing else.
Yeah, we are all on the same page, so i'm closing this PR.
Uh oh!
There was an error while loading. Please reload this page.
Added Local Storage Utility (support encode and decode) snippet (typescript)
image
image