Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Local Storage Utility (support encode and decode) #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Copy link

@marville001 marville001 commented Dec 30, 2024
edited
Loading

Added Local Storage Utility (support encode and decode) snippet (typescript)

image

image

Copy link

netlify bot commented Dec 30, 2024
edited
Loading

Deploy Preview for quicksnip ready!

Name Link
🔨 Latest commit ea5eb7c
🔍 Latest deploy log https://app.netlify.com/sites/quicksnip/deploys/677311f63371d40008ea860f
😎 Deploy Preview https://deploy-preview-46--quicksnip.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

If you strip the types it should be fine as far as I can read.
Perhaps you wish to add Typescript instead?

Copy link
Collaborator

Hey, thanks for your contribution to the repo.

Snippets to get, set and clear the localstorage already exists, it's true that putting them in a class is a new snippet, but I don't think it fits the scope of the project to put multiple snippets into one like this.

Let's get feedback from other on this topic.

marville001, Ashish-simpleCoder, and technoph1le reacted with thumbs up emoji

@technoph1le technoph1le added the discuss Needs to be discussed by community label Dec 31, 2024
Copy link

I think, snippets should be simple to understand and generalized.

Adding encoding and decoding is very specific scenario and few people will be able understand it.

And we should prefer Functional programming instead of class syntax.

And we can modify the existing snippet if want to add additional features.

Mathys-Gasnier reacted with thumbs up emoji

Copy link
Contributor

Axorax commented Dec 31, 2024

Personally, I have no use for this snippet. You can already do each of the actions with one line of code. And the encoding and decoding is just base64. New coder's might think it's making their data secure but it's just making it harder to read and nothing else.

Copy link
Collaborator

Yeah, we are all on the same page, so i'm closing this PR.

@Mathys-Gasnier Mathys-Gasnier added wontfix This will not be worked on and removed discuss Needs to be discussed by community labels Dec 31, 2024
@marville001 marville001 deleted the local-storage-utility branch December 31, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mathys-Gasnier Mathys-Gasnier Awaiting requested review from Mathys-Gasnier Mathys-Gasnier is a code owner

Assignees
No one assigned
Labels
Snippets wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /