-
-
Notifications
You must be signed in to change notification settings - Fork 130
add media query snippet for tailwindcss #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for quicksnip ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't modify this file, it is auto generated by a script and a github workflow, please revert the changes you made here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icon should be 50x50px, you can use tools such as resize-svg to resize it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding aria tags for accessibility; you can check the other SVG files as example.
<svg... aria-labelledby=tailwind-logo-titletailwind-logo-description"> <title id="tailwind-logo-title">Tailwind CSS Logo</title> <desc id="tailwind-logo-description">A light blue symbol made of two parallel wavy lines, similar to a tilde</desc>
tsconfig.app.tsbuildinfo
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your editor generated this file, please remove it
tsconfig.node.tsbuildinfo
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your editor generated this file, please remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like these snippets. I would suggest a few changes. Indicate that using min width is for a mobile first approach, and max-width is for a desktop-first approach. Also give the user some context on where to use this snippet. Like here. Give context like the file to paste it into and inside which field it should go into. Example:
// tailwind.config.js module.exports = { theme: { screens: { 'sm': '640px', 'md': '768px', 'lg': '1024px', 'xl': '1280px', '2xl': '1536px', } } }
made the required changes.
you forgot to remove the two .tsbuildinfo files you added
remove auto generated files
Includes media query snippet for tailwindCSS.