-
-
Notifications
You must be signed in to change notification settings - Fork 130
Add lightmode for accessibility #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Respects browser preference, uses local storage for settings saving. Some elements aren't colored correctly or look ugly.
✅ Deploy Preview for quicksnip ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Additional note: I was also looking into theming the code preview, but I think that would work best with a second setting. As some might still prefer to have their code in dark or lightmode regardless of the site theme. Maybe we could add another toggle similar to the clipboard button?
@GreenMan36 Adding light mode is a great idea. Later on, we can play around with the colors for the better contrast and accessibility. I am thinking to refactor the custom properties for the specific elements instead of general --neutral colors.
Side Note: Initial design of this project was in light mode. Since developers hate light mode, I had switched to dark mode. 😅
I actually just got the theming for the code preview, I just can't figure out how the hover color is done.
Personally, I'm not a fan of lightmode. I am however, a fan of accessibility, and I know a few people with contrast loss or partial blindness.
Lightmode is an accessibility option for those so I've implemented that. This paves the way for other improvements in the future.
Some notes:
image